Просмотр исходного кода

refactor(touch): remove console.log debug statements from QML

Removed 73 verbose debug logs from QML files:
- main.qml: navigation, screen state, touch events
- ConnectionStatus.qml: backend state logging
- BottomNavTab.qml: icon value logging
- ThemeManager.qml: dark mode toggle
- TableControlPage.qml: serial connection state
- ModernPlaylistPage.qml: playlist operations
- ExecutionPage.qml: image loading, execution signals
- PatternSelectorPage.qml: pattern selection

QML doesn't support log levels, so debug output is removed entirely.
For debugging, re-add console.log statements as needed.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
tuanchris 1 неделя назад
Родитель
Сommit
8bd5cec165

+ 0 - 2
dune-weaver-touch/qml/components/BottomNavTab.qml

@@ -32,7 +32,6 @@ Rectangle {
             property string iconValue: parent.parent.icon
             text: {
                 // Debug log the icon value
-                console.log("BottomNavTab icon value:", iconValue)
 
                 // Map icon names to Unicode symbols that work on Raspberry Pi
                 switch(iconValue) {
@@ -42,7 +41,6 @@ Rectangle {
                     case "play_arrow": return "▶"   // U+25B6 - Play without variant selector
                     case "lightbulb": return "☀"   // U+2600 - Sun symbol for LED
                     default: {
-                        console.log("Unknown icon:", iconValue, "- using default")
                         return "□"  // U+25A1 - Simple box, universally supported
                     }
                 }

+ 0 - 7
dune-weaver-touch/qml/components/ConnectionStatus.qml

@@ -12,12 +12,10 @@ Rectangle {
     // Direct property binding to backend.serialConnected
     color: {
         if (!backend) {
-            console.log("ConnectionStatus: No backend available")
             return "#FF5722"  // Red if no backend
         }
         
         var connected = backend.serialConnected
-        console.log("ConnectionStatus: backend.serialConnected =", connected)
         
         if (connected === true) {
             return "#4CAF50"  // Green if connected
@@ -31,23 +29,18 @@ Rectangle {
         target: backend
         
         function onSerialConnectionChanged(connected) {
-            console.log("ConnectionStatus: serialConnectionChanged signal received:", connected)
             // The color binding will automatically update
         }
     }
     
     // Debug logging
     Component.onCompleted: {
-        console.log("ConnectionStatus: Component completed, backend =", backend)
         if (backend) {
-            console.log("ConnectionStatus: initial serialConnected =", backend.serialConnected)
         }
     }
     
     onBackendChanged: {
-        console.log("ConnectionStatus: backend changed to", backend)
         if (backend) {
-            console.log("ConnectionStatus: new backend serialConnected =", backend.serialConnected)
         }
     }
     

+ 0 - 1
dune-weaver-touch/qml/components/ThemeManager.qml

@@ -67,7 +67,6 @@ QtObject {
     onDarkModeChanged: {
         // Save preference
         settings.darkMode = darkMode
-        console.log("🎨 Dark mode:", darkMode ? "enabled" : "disabled")
     }
 
     // Helper function to get contrast color

+ 0 - 18
dune-weaver-touch/qml/main.qml

@@ -25,22 +25,17 @@ ApplicationWindow {
     property string currentPatternPreview: ""
 
     onCurrentPageIndexChanged: {
-        console.log("📱 currentPageIndex changed to:", currentPageIndex)
     }
 
     onShouldNavigateToExecutionChanged: {
         if (shouldNavigateToExecution) {
-            console.log("🎯 Navigating to execution page")
-            console.log("🎯 Current stack depth:", stackView.depth)
 
             // If we're in a sub-page (like PatternDetailPage), pop back to main view first
             if (stackView.depth > 1) {
-                console.log("🎯 Popping back to main view first")
                 stackView.pop()
             }
 
             // Then navigate to ExecutionPage tab (index 4)
-            console.log("🎯 Setting currentPageIndex to 4")
             currentPageIndex = 4
             shouldNavigateToExecution = false
         }
@@ -50,14 +45,11 @@ ApplicationWindow {
         id: backend
         
         onExecutionStarted: function(patternName, patternPreview) {
-            console.log("🎯 QML: ExecutionStarted signal received! patternName='" + patternName + "', preview='" + patternPreview + "'")
-            console.log("🎯 Setting shouldNavigateToExecution = true")
             // Store pattern info for ExecutionPage
             window.currentPatternName = patternName
             window.currentPatternPreview = patternPreview
             // Navigate to Execution tab (index 3) instead of pushing page
             shouldNavigateToExecution = true
-            console.log("🎯 shouldNavigateToExecution set to:", shouldNavigateToExecution)
         }
         
         onErrorOccurred: function(error) {
@@ -72,16 +64,12 @@ ApplicationWindow {
         }
         
         onScreenStateChanged: function(isOn) {
-            console.log("🖥️ Screen state changed:", isOn ? "ON" : "OFF")
         }
         
         onBackendConnectionChanged: function(connected) {
-            console.log("🔗 Backend connection changed:", connected)
             if (connected && stackView.currentItem.toString().indexOf("ConnectionSplash") !== -1) {
-                console.log("✅ Backend connected, switching to main view")
                 stackView.replace(mainSwipeView)
             } else if (!connected && stackView.currentItem.toString().indexOf("ConnectionSplash") === -1) {
-                console.log("❌ Backend disconnected, switching to splash screen")
                 stackView.replace(connectionSplash)
             }
         }
@@ -95,17 +83,14 @@ ApplicationWindow {
         propagateComposedEvents: true
         
         onPressed: {
-            console.log("🖥️ QML: Touch/press detected - resetting activity timer")
             backend.resetActivityTimer()
         }
         
         onPositionChanged: {
-            console.log("🖥️ QML: Mouse movement detected - resetting activity timer")
             backend.resetActivityTimer()
         }
         
         onClicked: {
-            console.log("🖥️ QML: Click detected - resetting activity timer")
             backend.resetActivityTimer()
         }
     }
@@ -134,7 +119,6 @@ ApplicationWindow {
                 showRetryButton: backend.reconnectStatus === "Cannot connect to backend"
                 
                 onRetryConnection: {
-                    console.log("🔄 Manual retry requested")
                     backend.retryConnection()
                 }
             }
@@ -154,7 +138,6 @@ ApplicationWindow {
                     currentIndex: window.currentPageIndex
                     
                     Component.onCompleted: {
-                        console.log("📱 StackLayout created with currentIndex:", currentIndex, "bound to window.currentPageIndex:", window.currentPageIndex)
                     }
                     
                     // Patterns Page
@@ -214,7 +197,6 @@ ApplicationWindow {
                     currentIndex: window.currentPageIndex
                     
                     onTabClicked: function(index) {
-                        console.log("📱 Tab clicked:", index)
                         window.currentPageIndex = index
                     }
                 }

+ 0 - 18
dune-weaver-touch/qml/pages/ExecutionPage.qml

@@ -14,17 +14,12 @@ Page {
     
     // Debug backend connection
     onBackendChanged: {
-        console.log("ExecutionPage: backend changed to", backend)
         if (backend) {
-            console.log("ExecutionPage: backend.serialConnected =", backend.serialConnected)
-            console.log("ExecutionPage: backend.isConnected =", backend.isConnected)
         }
     }
     
     Component.onCompleted: {
-        console.log("ExecutionPage: Component completed, backend =", backend)
         if (backend) {
-            console.log("ExecutionPage: initial serialConnected =", backend.serialConnected)
         }
     }
     
@@ -33,20 +28,14 @@ Page {
         target: backend
 
         function onSerialConnectionChanged(connected) {
-            console.log("ExecutionPage: received serialConnectionChanged signal:", connected)
         }
 
         function onConnectionChanged() {
-            console.log("ExecutionPage: received connectionChanged signal")
             if (backend) {
-                console.log("ExecutionPage: after connectionChanged, serialConnected =", backend.serialConnected)
             }
         }
 
         function onExecutionStarted(fileName, preview) {
-            console.log("🎯 ExecutionPage: executionStarted signal received!")
-            console.log("🎯 Pattern:", fileName)
-            console.log("🎯 Preview path:", preview)
             // Update preview directly from backend signal
             patternName = fileName
             patternPreview = preview
@@ -125,9 +114,7 @@ Page {
                             if (patternPreview) {
                                 // Backend returns absolute path, just add file:// prefix
                                 finalSource = "file://" + patternPreview
-                                console.log("🖼️ Using backend patternPreview:", finalSource)
                             } else {
-                                console.log("🖼️ No preview from backend")
                             }
 
                             return finalSource
@@ -135,18 +122,13 @@ Page {
                         fillMode: Image.PreserveAspectFit
 
                         onStatusChanged: {
-                            console.log("📷 Image status:", status, "for source:", source)
                             if (status === Image.Error) {
-                                console.log("❌ Image failed to load:", source)
                             } else if (status === Image.Ready) {
-                                console.log("✅ Image loaded successfully:", source)
                             } else if (status === Image.Loading) {
-                                console.log("🔄 Image loading:", source)
                             }
                         }
 
                         onSourceChanged: {
-                            console.log("🔄 Image source changed to:", source)
                         }
                         
                         Rectangle {

+ 0 - 1
dune-weaver-touch/qml/pages/ModernPatternListPage.qml

@@ -18,7 +18,6 @@ Page {
     Connections {
         target: backend
         function onPatternsRefreshCompleted(success, message) {
-            console.log("🔄 Pattern refresh completed:", success, message)
             if (patternModel) {
                 patternModel.refresh()
             }

+ 0 - 18
dune-weaver-touch/qml/pages/ModernPlaylistPage.qml

@@ -34,7 +34,6 @@ Page {
         if (selectedPlaylist) {
             currentPlaylistPatterns = playlistModel.getPatternsForPlaylist(selectedPlaylist)
             currentPlaylistRawPatterns = playlistModel.getRawPatternsForPlaylist(selectedPlaylist)
-            console.log("Loaded patterns for", selectedPlaylist + ":", currentPlaylistPatterns)
         } else {
             currentPlaylistPatterns = []
             currentPlaylistRawPatterns = []
@@ -52,8 +51,6 @@ Page {
     
     // Debug playlist loading
     Component.onCompleted: {
-        console.log("ModernPlaylistPage completed, playlist count:", playlistModel.rowCount())
-        console.log("showingPlaylistDetail:", showingPlaylistDetail)
     }
     
     // Function to navigate to playlist detail
@@ -548,7 +545,6 @@ Page {
                                         anchors.fill: parent
                                         onClicked: {
                                             if (backend) {
-                                                console.log("Playing playlist:", selectedPlaylist, "with settings:", {
                                                     pauseTime: pauseTime,
                                                     clearPattern: clearPattern,
                                                     runMode: runMode,
@@ -557,12 +553,9 @@ Page {
                                                 backend.executePlaylist(selectedPlaylist, pauseTime, clearPattern, runMode, shuffle)
                                                 
                                                 // Navigate to execution page
-                                                console.log("🎵 Navigating to execution page after playlist start")
                                                 if (mainWindow) {
-                                                    console.log("🎵 Setting shouldNavigateToExecution = true")
                                                     mainWindow.shouldNavigateToExecution = true
                                                 } else {
-                                                    console.log("🎵 ERROR: mainWindow is null, cannot navigate")
                                                 }
                                             }
                                         }
@@ -590,7 +583,6 @@ Page {
                                             var newValue = !shuffle
                                             shuffle = newValue
                                             if (backend) backend.setPlaylistShuffle(newValue)
-                                            console.log("Shuffle toggled:", shuffle)
                                         }
                                     }
                                 }
@@ -654,7 +646,6 @@ Page {
                                                 onClicked: {
                                                     runMode = "single"
                                                     if (backend) backend.setPlaylistRunMode("single")
-                                                    console.log("Run mode set to:", runMode)
                                                 }
 
                                                 contentItem: Text {
@@ -674,7 +665,6 @@ Page {
                                                 onClicked: {
                                                     runMode = "loop"
                                                     if (backend) backend.setPlaylistRunMode("loop")
-                                                    console.log("Run mode set to:", runMode)
                                                 }
 
                                                 contentItem: Text {
@@ -1101,7 +1091,6 @@ Page {
                                                 onClicked: {
                                                     clearPattern = "adaptive"
                                                     if (backend) backend.setPlaylistClearPattern("adaptive")
-                                                    console.log("Clear pattern set to:", clearPattern)
                                                 }
 
                                                 contentItem: Text {
@@ -1121,7 +1110,6 @@ Page {
                                                 onClicked: {
                                                     clearPattern = "clear_center"
                                                     if (backend) backend.setPlaylistClearPattern("clear_center")
-                                                    console.log("Clear pattern set to:", clearPattern)
                                                 }
 
                                                 contentItem: Text {
@@ -1141,7 +1129,6 @@ Page {
                                                 onClicked: {
                                                     clearPattern = "clear_perimeter"
                                                     if (backend) backend.setPlaylistClearPattern("clear_perimeter")
-                                                    console.log("Clear pattern set to:", clearPattern)
                                                 }
 
                                                 contentItem: Text {
@@ -1161,7 +1148,6 @@ Page {
                                                 onClicked: {
                                                     clearPattern = "none"
                                                     if (backend) backend.setPlaylistClearPattern("none")
-                                                    console.log("Clear pattern set to:", clearPattern)
                                                 }
 
                                                 contentItem: Text {
@@ -1407,7 +1393,6 @@ Page {
         target: backend
 
         function onPlaylistCreated(success, message) {
-            console.log("📋 Playlist created:", success, message)
             if (success) {
                 playlistModel.refresh()
             }
@@ -1416,7 +1401,6 @@ Page {
         }
 
         function onPlaylistDeleted(success, message) {
-            console.log("🗑️ Playlist deleted:", success, message)
             if (success) {
                 playlistModel.refresh()
                 showPlaylistList()  // Navigate back to list
@@ -1424,7 +1408,6 @@ Page {
         }
 
         function onPatternAddedToPlaylist(success, message) {
-            console.log("➕ Pattern added to playlist:", success, message)
             if (success) {
                 playlistModel.refresh()
                 // Refresh current playlist patterns if we're viewing one
@@ -1436,7 +1419,6 @@ Page {
         }
 
         function onPlaylistModified(success, message) {
-            console.log("📝 Playlist modified:", success, message)
             if (success) {
                 playlistModel.refresh()
                 // Refresh current playlist patterns

+ 0 - 1
dune-weaver-touch/qml/pages/PatternDetailPage.qml

@@ -488,7 +488,6 @@ Page {
         target: backend
 
         function onPatternAddedToPlaylist(success, message) {
-            console.log("➕ Pattern added to playlist:", success, message)
             if (success) {
                 // Show feedback
                 showAddedFeedback = true

+ 0 - 3
dune-weaver-touch/qml/pages/PatternSelectorPage.qml

@@ -368,7 +368,6 @@ Page {
 
         function onPatternAddedToPlaylist(success, message) {
             if (success) {
-                console.log("Pattern added to playlist, refreshing selection state")
                 // Extract the pattern name from the message if possible
                 // The message format is typically "Pattern added to playlist"
                 // We'll track additions in sessionAddedPatterns instead
@@ -387,8 +386,6 @@ Page {
 
     // Override the click handler to track additions
     Component.onCompleted: {
-        console.log("PatternSelectorPage loaded for playlist:", playlistName)
-        console.log("Existing patterns:", existingPatterns)
     }
 
     // Function to add pattern and track it

+ 0 - 4
dune-weaver-touch/qml/pages/TableControlPage.qml

@@ -18,17 +18,14 @@ Page {
         target: backend
         
         function onSerialPortsUpdated(ports) {
-            console.log("Serial ports updated:", ports)
             serialPorts = ports
         }
         
         function onSerialConnectionChanged(connected) {
-            console.log("Serial connection changed:", connected)
             isSerialConnected = connected
         }
         
         function onCurrentPortChanged(port) {
-            console.log("Current port changed:", port)
             if (port) {
                 selectedPort = port
             }
@@ -36,7 +33,6 @@ Page {
         
         
         function onSettingsLoaded() {
-            console.log("Settings loaded")
             if (backend) {
                 autoPlayOnBoot = backend.autoPlayOnBoot
                 isSerialConnected = backend.serialConnected